Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Remove TLS certificate rotation #5318

Merged
merged 2 commits into from
Aug 17, 2023
Merged

go: Remove TLS certificate rotation #5318

merged 2 commits into from
Aug 17, 2023

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Jul 11, 2023

No description provided.

kostko
kostko reviewed Jul 23, 2023
View reviewed changes
runtime/src/consensus/registry.rs Outdated Show resolved Hide resolved
go/common/node/node.go Outdated Show resolved Hide resolved
go/common/identity/identity.go Outdated Show resolved Hide resolved
go/common/identity/identity.go Outdated Show resolved Hide resolved
kostko
kostko reviewed Aug 1, 2023
View reviewed changes
runtime/src/consensus/registry.rs Outdated Show resolved Hide resolved
runtime/src/consensus/registry.rs Show resolved Hide resolved
@kostko kostko marked this pull request as ready for review August 1, 2023 16:03
peternose
peternose reviewed Aug 1, 2023
View reviewed changes
docs/oasis-node/cli.md Outdated Show resolved Hide resolved
go/common/identity/identity.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/node/node_control.go Outdated Show resolved Hide resolved
runtime/src/consensus/state/registry.rs Show resolved Hide resolved
runtime/src/consensus/registry.rs Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/rotation branch 2 times, most recently from 2460e98 to 219ff43 Compare August 11, 2023 01:29
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #5318 (a683d30) into master (b62f53c) will increase coverage by 0.08%.
Report is 1 commits behind head on master.
The diff coverage is 93.65%.

@@            Coverage Diff             @@
##           master    #5318      +/-   ##
==========================================
+ Coverage   66.82%   66.90%   +0.08%     
==========================================
  Files         525      525              
  Lines       55907    55763     -144     
==========================================
- Hits        37360    37311      -49     
+ Misses      13983    13909      -74     
+ Partials     4564     4543      -21
Files Changed Coverage Δ
go/worker/common/committee/accessctl.go 0.00% <ø> (ø)
go/oasis-node/cmd/identity/identity.go 52.17% <50.00%> (ø)
go/common/node/node.go 75.00% <66.66%> (+1.47%) ⬆️
go/common/identity/identity.go 78.31% <90.90%> (+5.17%) ⬆️
go/common/grpc/grpc.go 75.86% <100.00%> (ø)
go/consensus/cometbft/tests/genesis/genesis.go 91.48% <100.00%> (-0.24%) ⬇️
go/ias/proxy/client/client.go 62.16% <100.00%> (ø)
go/oasis-node/cmd/common/grpc/grpc.go 82.69% <100.00%> (-0.33%) ⬇️
go/oasis-node/cmd/node/init.go 40.24% <100.00%> (ø)
go/oasis-node/cmd/node/node_control.go 53.81% <100.00%> (ø)
... and 5 more

... and 51 files with indirect coverage changes

kostko
kostko approved these changes Aug 16, 2023
View reviewed changes
go/common/identity/identity.go Outdated Show resolved Hide resolved
@jberci jberci merged commit b8ff03d into master Aug 17, 2023
3 checks passed
@jberci jberci deleted the jberci/feature/rotation branch August 17, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternose peternose peternose approved these changes

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jberci @kostko @peternose